libbpf: Add debug messaging in dedup equivalence/identity matching #10343
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: e0940c6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b0a5b86 to
44cbecf
Compare
Author
|
Upstream branch: 792f258 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
414e8ee to
75c2826
Compare
Author
|
Upstream branch: 792f258 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
75c2826 to
2c0a2c7
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
44cbecf to
e8ba78a
Compare
Author
|
Upstream branch: 878ee3c |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
2c0a2c7 to
7de6cf9
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e8ba78a to
c1a1f03
Compare
Author
|
Upstream branch: ae24fc8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
7de6cf9 to
7ce4e39
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c1a1f03 to
ca453f8
Compare
Author
|
Upstream branch: 4dd3a48 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
7ce4e39 to
8b3585f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
ca453f8 to
b3f74e5
Compare
Author
|
Upstream branch: 8f7cf30 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
8b3585f to
990f909
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
b3f74e5 to
b57110f
Compare
Author
|
Upstream branch: c427320 |
We have seen a number of issues like [1]; failures to deduplicate key kernel data structures like task_struct. These are often hard to debug from pahole even with verbose output, especially when identity/equivalence checks fail deep in a nested struct comparison. Here we add debug messages of the form libbpf: struct 'task_struct' (size 2560 vlen 194) appears equivalent but differs for 23-indexed cand/canon member 'sched_class'/'sched_class': 0 These will be emitted during dedup from pahole when --verbose/-V is specified. This greatly helps identify exactly where dedup failures are experienced. [1] https://lore.kernel.org/bpf/b8e8b560-bce5-414b-846d-0da6d22a9983@oracle.com/ Signed-off-by: Alan Maguire <alan.maguire@oracle.com> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1026051=>bpf-next
branch
from
990f909 to
b0bc5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: Add debug messaging in dedup equivalence/identity matching
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1026051