Skip to content

Commit

Permalink
Merge branch 'xen-netfront-fixes'
Browse files Browse the repository at this point in the history
Ross Lagerwall says:

====================
xen-netfront: Fix issues with commit f599c64

Fix a couple of issues with commit f599c64 ("xen-netfront: Fix race
between device setup and open").
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
davem330 committed Jun 21, 2018
2 parents 44a5cd4 + 45c8184 commit 962c661
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions drivers/net/xen-netfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,7 @@ static int talk_to_netback(struct xenbus_device *dev,
err = xen_net_read_mac(dev, info->netdev->dev_addr);
if (err) {
xenbus_dev_fatal(dev, err, "parsing %s/mac", dev->nodename);
goto out;
goto out_unlocked;
}

rtnl_lock();
Expand Down Expand Up @@ -1925,6 +1925,7 @@ static int talk_to_netback(struct xenbus_device *dev,
xennet_destroy_queues(info);
out:
rtnl_unlock();
out_unlocked:
device_unregister(&dev->dev);
return err;
}
Expand All @@ -1950,10 +1951,6 @@ static int xennet_connect(struct net_device *dev)
/* talk_to_netback() sets the correct number of queues */
num_queues = dev->real_num_tx_queues;

rtnl_lock();
netdev_update_features(dev);
rtnl_unlock();

if (dev->reg_state == NETREG_UNINITIALIZED) {
err = register_netdev(dev);
if (err) {
Expand All @@ -1963,6 +1960,10 @@ static int xennet_connect(struct net_device *dev)
}
}

rtnl_lock();
netdev_update_features(dev);
rtnl_unlock();

/*
* All public and private state should now be sane. Get
* ready to start sending and receiving packets and give the driver
Expand Down

0 comments on commit 962c661

Please sign in to comment.