Skip to content

Commit

Permalink
zonefs: use zone write granularity as block size
Browse files Browse the repository at this point in the history
Zoned block devices have different granularity constraints for write
operations into sequential zones. E.g. ZBC and ZAC devices require that
writes be aligned to the device physical block size while NVMe ZNS
devices allow logical block size aligned write operations. To correctly
handle such difference, use the device zone write granularity limit to
set the block size of a zonefs volume, thus allowing the smallest
possible write unit for all zoned device types.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@edc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
damien-lemoal authored and axboe committed Feb 10, 2021
1 parent a805a4f commit 0f1ba5f
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions fs/zonefs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1581,12 +1581,11 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)
sb->s_time_gran = 1;

/*
* The block size is set to the device physical sector size to ensure
* that write operations on 512e devices (512B logical block and 4KB
* physical block) are always aligned to the device physical blocks,
* as mandated by the ZBC/ZAC specifications.
* The block size is set to the device zone write granularity to ensure
* that write operations are always aligned according to the device
* interface constraints.
*/
sb_set_blocksize(sb, bdev_physical_block_size(sb->s_bdev));
sb_set_blocksize(sb, bdev_zone_write_granularity(sb->s_bdev));
sbi->s_zone_sectors_shift = ilog2(bdev_zone_sectors(sb->s_bdev));
sbi->s_uid = GLOBAL_ROOT_UID;
sbi->s_gid = GLOBAL_ROOT_GID;
Expand Down

0 comments on commit 0f1ba5f

Please sign in to comment.