Fix two tailcall-related issues #5544
Open
+80
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: c4b1be9 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8c57c04 to
b70eeea
Compare
|
Upstream branch: 26d0e53 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
2055d2c to
64ba538
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
b70eeea to
21b4b7a
Compare
|
Upstream branch: 0df1a55 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
64ba538 to
4cc19ae
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
21b4b7a to
7bebef6
Compare
|
Upstream branch: cce3fee |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
4cc19ae to
bcdfac1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
7bebef6 to
098b57c
Compare
|
Upstream branch: 1230be8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
bcdfac1 to
2459d44
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
098b57c to
04b85e4
Compare
|
Upstream branch: 212ec92 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
2459d44 to
7c3df11
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
04b85e4 to
e254fff
Compare
|
Upstream branch: 621af19 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
7c3df11 to
e9468b9
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e254fff to
6421a08
Compare
|
Upstream branch: 564606f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
e9468b9 to
a851c43
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6421a08 to
d84ad1e
Compare
|
Upstream branch: 38d95be |
added 2 commits
July 2, 2025 11:47
…emit_bpf_tail_call function For a ebpf subprog JIT，the last call bpf_int_jit_compile function will directly enter the skip_init_ctx process. At this point, out_offset = -1, the jmp_offset in emit_bpf_tail_call is calculated by #define jmp_offset (out_offset - (cur_offset)) is a negative number, which does not meet expectations.The final generated assembly as follow. 54: bgeu $a2, $t1, -8 # 0x0000004c 58: addi.d $a6, $s5, -1 5c: bltz $a6, -16 # 0x0000004c 60: alsl.d $t2, $a2, $a1, 0x3 64: ld.d $t2, $t2, 264 68: beq $t2, $zero, -28 # 0x0000004c Before apply this patch, the follow test case will reveal soft lock issues. cd tools/testing/selftests/bpf/ ./test_progs --allow=tailcalls/tailcall_bpf2bpf_1 dmesg: watchdog: BUG: soft lockup - CPU#2 stuck for 26s! [test_progs:25056] Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
In specific use cases combining tailcalls and BPF-to-BPF calls， MAX_TAIL_CALL_CNT won't work because of missing tail_call_cnt back-propagation from callee to caller。This patch fixes this tailcall issue caused by abusing the tailcall in bpf2bpf feature on LoongArch like the way of "bpf, x64: Fix tailcall hierarchy". push tail_call_cnt_ptr and tail_call_cnt into the stack, tail_call_cnt_ptr is passed between tailcall and bpf2bpf, uses tail_call_cnt_ptr to increment tail_call_cnt. Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/977599=>bpf-next
branch
from
a851c43 to
295f728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Fix two tailcall-related issues
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=977599