Skip to content

Upgrade: react-native-reanimated 1 to 2x - #45

Open
NileshPatel17 wants to merge 1 commit into
keremcubuk:masterfrom
NileshPatel17:reanimated2x
Open

Upgrade: react-native-reanimated 1 to 2x#45
NileshPatel17 wants to merge 1 commit into
keremcubuk:masterfrom
NileshPatel17:reanimated2x

Conversation

@NileshPatel17

@NileshPatel17 NileshPatel17 commented Jan 8, 2022

Copy link
Copy Markdown

@keremcubuk tested in android emulator and ios simulator, works fine.

Here is the Preview:

Untitled.mp4

@NileshPatel17 NileshPatel17 changed the title Upgrade: reanimated 1 to 2x Upgrade: react-native-reanimated 1 to 2x Jan 8, 2022
@keremcubuk

Copy link
Copy Markdown
Owner

Hi @NileshPatel17, thank you for your contribution but I have some questions in my mind. These are:

  • Should we add many custom changes for the template project?
  • Is it possible, can we solve without touching gradle files?
  • Should we use hermes? Because you need also add hermes-engine package for release build.

I will evaluate and research as soon as possible.

I want to learn your opinion about these questions.

Thank you for your support 馃檹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants