Adding environ argument to enable testing of forms#9
Open
oceanites wants to merge 4 commits intokeredson:masterfrom
oceanites:master
Open
Adding environ argument to enable testing of forms#9oceanites wants to merge 4 commits intokeredson:masterfrom oceanites:master
oceanites wants to merge 4 commits intokeredson:masterfrom
oceanites:master
Conversation
…g the inner context manager
…already uses forms internally.
…a. This can be used to add extra argument 'forms'
|
This seems also be useful/needed to test routes with Basic Auth to set the REMOTE_USER environment variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to test my application using boddle and stumpled upon two problems:
boddle(beaker.session='session')obviously doesn't work (It tries to access attribute session from a not existing beaker object), as well asboddle('beaker.session'='session')boddle(**{'beaker.session': 'session'}), the value is stored inbottle.request.ext.beaker.sessionand therefore, only accessible withgetattr(bottle.request, 'beaker.session')To solve this issue i propose adding an extra argument
environfor the context manager. This solves both issues, forms can be preset withboddle(environ={'bottle.request.forms': formdata}). Beaker session data usingboddle(environ={'beaker.session': sessiondata}).