Skip to content

Commit

Permalink
chore(contrib): Add testing guidelines for versions
Browse files Browse the repository at this point in the history
0.56 was a fairly major release changing the underlying versions of
system dependencies, like gradle
  • Loading branch information
kattrali committed Nov 8, 2018
1 parent 58a06d9 commit 4e922be
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ make ANDROID_VERSION=X IOS_VERSION=X upgrade_vendor
- [ ] Have the changelog and README been updated?
- [ ] Have all the version numbers been incremented?
- [ ] Has all new functionality been manually tested on a release build? Use `npm pack` to generate an artifact to install in a new app.
- [ ] Install on Android/iOS in an app running the latest version of RN
- [ ] Install on Android/iOS in an app < 0.56
- [ ] Ensure the example app sends the correct error for each type on iOS and Android
- [ ] Archive the iOS app and validate the bundle type
- [ ] Generate a signed APK for Android
Expand Down

0 comments on commit 4e922be

Please sign in to comment.