Fix cuDNN tests #8189
Merged
Fix cuDNN tests #8189
+24
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Oct 19, 2017
| @@ -122,46 +122,45 @@ def test_cudnn_rnn_canonical_to_params_gru(): | |||
|
|
|||
|
|
|||
| @keras_test | |||
| @pytest.mark.parametrize("rnn_type", ['lstm', 'gru'], ids=['LSTM', 'GRU']) | |||
There was a problem hiding this comment.
Use ' as string delimiter for consistency
| input_size = 30 | ||
| timesteps = 50 | ||
| units = 128 | ||
| num_samples = 640 |
There was a problem hiding this comment.
I would recommend a greater number of units, timesteps, and samples (like the original values). This test does not run on CI so it does not need to be fast. Think of it as a benchmark, not a unit test.
Move `times = []` from the outer to the inner loop Delete `clear_session()` which is redundant with `keras_test` Reduce the example size under the 3x speed-up is satisfied
taehoonlee
force-pushed
the
fix_cudnn_rnn_tests
branch
from
2091e17
to
d62bd7a
Compare
|
Updated. Thank you for the comments @fchollet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
times = []from the outer to the inner loop (because the speed-up is calculated for each inner loop)Delete
clear_session()which is redundant withkeras_test(thus the outer loop should be transformed topytest.mark.parametrize)Reduce the example size under the 3x speed-up is satisfied (the sample size 10000 is too large)