Sort files in DirectoryIterator because os.walk orders them arbitrarily #7869
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filenames yielded by the
DirectoryIterator
are in arbitrary order because it usesos.walk
(which usesos.listdir
under the hood. The docs foros.listdir
mention that the filenames are ordered arbitrarily: https://docs.python.org/3/library/os.html#os.listdir . On Mac OSX, the filenames seem to be sorted lexicographically, but on Ubuntu 17.04 with ext4 filesystem, they seem to be given in an arbitary, non-lexicographic order.The Keras docs give an example of combining images with masks using
flow_from_directory
, which requires that the files be sorted: https://keras.io/preprocessing/image/ . This fix is important for that to work on all systems.Fixes #6418