Correct implementation for several OpenVINO operations

[danielenricocahall]

• Enable unit tests for mean, max, and floor (while ensuring tests with overlapping names, such as test_maximum... are still skipped for the time being)
• Correct implementations for mean, max, and floor operations
• Consolidate some otherwise duplicated logic (note: should these go into an op_utils module?)

[gemini-code-assist]

Summary of Changes

Hello @danielenricocahall, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the OpenVINO backend by addressing and correcting the implementations of key numerical operations such as "mean", "max", and "floor". It also expands test coverage by enabling previously excluded unit tests for these operations. The changes include a refactoring effort to consolidate redundant logic for "min" and "max" into a shared utility function, leading to a more robust and maintainable codebase for the OpenVINO backend.

Highlights

• Test Enablement: Unit tests for "mean", "max", and "floor" operations in the OpenVINO backend are now enabled by removing them from the exclusion list, improving test coverage.
• Corrected "mean" Implementation: The "mean" operation now correctly handles integral input types by converting them to float before computation and utilizes a new "_resolve_axis" helper for consistent axis processing.
• Corrected "floor" Implementation: The "floor" operation now includes a type conversion for integral inputs to float, ensuring correct behavior across different data types.
• Consolidated "min" and "max" Logic: A new internal helper function, "_compute_extrema", has been introduced to centralize the implementation logic for "min" and "max" operations, handling "initial" values, boolean type conversions, and axis resolution.
• Refactored Axis Resolution: A dedicated "_resolve_axis" helper function was added to streamline the processing of the "axis" argument across various reduction operations like "mean", "amax", "amin", "min", and "max".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces correct implementations for several OpenVINO operations (mean, max, floor) and enables their unit tests, which is a great step forward. The consolidation of duplicated logic for min/max into _compute_extrema and axis handling into _resolve_axis improves code maintainability. However, I've identified a couple of issues related to keepdims=True when axis=None that affect both mean and _compute_extrema (and by extension max and min). The proposed fixes should ensure NumPy-compliant behavior in these cases.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (14144cb) to head (805a26f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
keras/src/backend/openvino/numpy.py	92.30%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21746      +/-   ##
==========================================
- Coverage   82.62%   82.62%   -0.01%     
==========================================
  Files         572      572              
  Lines       58499    58518      +19     
  Branches     9143     9147       +4     
==========================================
+ Hits        48336    48350      +14     
- Misses       7838     7841       +3     
- Partials     2325     2327       +2     

Flag	Coverage Δ
keras	82.42% <92.30%> (-0.01%)	⬇️
keras-jax	63.20% <3.07%> (-0.02%)	⬇️
keras-numpy	57.56% <0.00%> (-0.02%)	⬇️
keras-openvino	34.38% <92.30%> (+0.03%)	⬆️
keras-tensorflow	63.95% <3.07%> (-0.02%)	⬇️
keras-torch	63.49% <3.07%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.