Version bump to 3.11.3 #21607
Version bump to 3.11.3 #21607
Conversation
…s-team#21575) Raise an exception and explain the user about the risks.
Also: - made various error messages related to `safe_mode` more consistent - removed no-op renaming code in legacy saving - uncommented unit tests in `serialization_lib_test.py`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @rtg0795, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request bumps the Keras version to 3.11.3, primarily integrating several cherry-picked fixes and security enhancements. The core focus is on strengthening the deserialization process across various model components, including Lambda layers, HDF5-saved models, and PyTorch modules, by introducing and enforcing a safe_mode to mitigate arbitrary code execution risks. Additionally, it addresses a specific issue with GRU layer state handling.
Highlights
- Version Update: The Keras library version has been updated to 3.11.3.
- Enhanced Safe Deserialization: Improved security by preventing arbitrary code execution during the deserialization of Lambda layers, HDF5 models, and PyTorch modules when safe_mode is enabled.
- GRU Layer State Fix: Corrected the return format for the state in the TensorFlow backend's CuDNN GRU implementation.
- Legacy Code Removal: Deprecated and unnecessary compatibility utilities related to serialization have been removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a version bump to 3.11.3 and includes several important changes cherry-picked from other pull requests. The changes include a bug fix in the cuDNN GRU implementation for consistent state formatting, and significant security enhancements by adding a safe_mode flag to prevent arbitrary code execution when deserializing models with Lambda layers or torch.nn.Module instances. Additionally, the PR removes some dead code and adds new tests to cover these fixes and enhancements. The changes are well-implemented, thoroughly tested, and improve the overall security and robustness of the library. I have no further recommendations.
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## r3.11 #21607 +/- ##
=======================================
Coverage 82.71% 82.72%
=======================================
Files 567 567
Lines 56267 56270 +3
Branches 8797 8798 +1
=======================================
+ Hits 46544 46547 +3
Misses 7565 7565
Partials 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cherrypicks of :
#21575
#21602
#21603