Implement hypot function in keras.ops #21606
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new hypot function to keras.ops, enabling element-wise calculation of the hypotenuse of right triangles. This operation is mathematically equivalent to sqrt(x12 + x22) and supports broadcasting. The implementation covers NumPy, TensorFlow, PyTorch, and JAX backends, with an explicit exclusion for OpenVINO.
Highlights
- Introduced keras.ops.hypot: A new function for computing the element-wise hypotenuse of two tensors, x1 and x2, which is equivalent to sqrt(x12 + x22).
- Multi-backend support: The hypot function has been implemented and integrated across the JAX, NumPy, TensorFlow, and PyTorch backends, ensuring consistent behavior.
- OpenVINO exclusion: The hypot operation is explicitly marked as not supported for the OpenVINO backend, raising a NotImplementedError if attempted.
- API exposure and documentation: The new hypot function is exposed under keras.ops and keras.ops.numpy, complete with comprehensive docstrings and usage examples.
- Comprehensive testing: New tests have been added to keras/src/ops/numpy_test.py to verify the hypot function's symbolic shape inference, static shape behavior, correctness across various inputs, and dtype handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces keras.ops.hypot for element-wise hypotenuse calculation, with support for NumPy, JAX, PyTorch, and TensorFlow backends. The implementation is well-structured and includes necessary API exports and tests. My main feedback concerns the numerical stability of the TensorFlow backend implementation, which could fail with large or small input values. I've suggested a more robust implementation. I also recommended enhancing the tests to cover these numerical stability edge cases. Overall, this is a valuable addition to the Keras API.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21606 +/- ##
=========================================
Coverage ? 82.75%
=========================================
Files ? 572
Lines ? 57321
Branches ? 8970
=========================================
Hits ? 47435
Misses ? 7674
Partials ? 2212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
the
ready to pull
Adds keras.ops.hypot, which computes the element-wise hypotenuse of right triangles given two tensor inputs (x1 and x2).
Equivalent to computing sqrt(x12 + x22) with broadcasting support.
Supported across NumPy, TensorFlow, PyTorch, and JAX backends.
Not supported on OpenVINO.