-
Notifications
You must be signed in to change notification settings - Fork 19.6k
[OpenVINO backend] update convert_to_tensor #21469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[OpenVINO backend] update convert_to_tensor #21469
Conversation
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the convert_to_tensor
function in the OpenVINO backend to handle ov.Output
types. A suggestion has been made to add a check for None inputs to prevent potential errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fchollet, looks good to me. Recommend to merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21469 +/- ##
==========================================
- Coverage 82.81% 82.80% -0.01%
==========================================
Files 565 565
Lines 55520 55522 +2
Branches 8664 8665 +1
==========================================
Hits 45977 45977
- Misses 7428 7429 +1
- Partials 2115 2116 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f088418
to
30b8779
Compare
@fchollet
@rkazants