Skip to content

[OpenVINO backend] update convert_to_tensor #21469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mohamed-Ashraf273
Copy link
Contributor

@divyashreepathihalli
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the convert_to_tensor function in the OpenVINO backend to handle ov.Output types. A suggestion has been made to add a check for None inputs to prevent potential errors.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (d55a767) to head (30b8779).

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21469      +/-   ##
==========================================
- Coverage   82.81%   82.80%   -0.01%     
==========================================
  Files         565      565              
  Lines       55520    55522       +2     
  Branches     8664     8665       +1     
==========================================
  Hits        45977    45977              
- Misses       7428     7429       +1     
- Partials     2115     2116       +1     
Flag Coverage Δ
keras 82.61% <0.00%> (-0.01%) ⬇️
keras-jax 63.38% <0.00%> (-0.01%) ⬇️
keras-numpy 58.58% <0.00%> (-0.01%) ⬇️
keras-openvino 33.99% <0.00%> (-0.01%) ⬇️
keras-tensorflow 63.83% <0.00%> (-0.01%) ⬇️
keras-torch 63.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mohamed-Ashraf273 Mohamed-Ashraf273 force-pushed the update_convert_to_tensor branch from f088418 to 30b8779 Compare July 14, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants