Skip to content

[OpenVINO backend] support tob_k and enable tests #21436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mohamed-Ashraf273
Copy link
Contributor

@Mohamed-Ashraf273 Mohamed-Ashraf273 commented Jun 29, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.77%. Comparing base (e233825) to head (f0131f0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21436   +/-   ##
=======================================
  Coverage   82.76%   82.77%           
=======================================
  Files         565      565           
  Lines       55378    55386    +8     
  Branches     8646     8646           
=======================================
+ Hits        45833    45845   +12     
+ Misses       7442     7439    -3     
+ Partials     2103     2102    -1     
Flag Coverage Δ
keras 82.58% <100.00%> (+<0.01%) ⬆️
keras-jax 63.33% <0.00%> (-0.01%) ⬇️
keras-numpy 58.52% <0.00%> (-0.01%) ⬇️
keras-openvino 34.05% <100.00%> (+0.28%) ⬆️
keras-tensorflow 63.76% <0.00%> (-0.01%) ⬇️
keras-torch 63.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned requested a review from mattdangerw June 30, 2025 08:18
@gbaned gbaned added this to PR Queue Jun 30, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue Jun 30, 2025
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

@divyashreepathihalli
Copy link
Collaborator

@Mohamed-Ashraf273 can you please resolve the conficts?

@divyashreepathihalli
Copy link
Collaborator

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR implements top_k for the OpenVINO backend and enables the math operations test suite. The implementation of top_k looks correct.

My main feedback is regarding the test exclusions. While it's a valid strategy to enable a whole test file and then exclude failing tests, I noticed that test_logsumexp is being excluded, even though logsumexp seems to be implemented. This might indicate a bug in the existing implementation. Please see my detailed comment.

Also, there's a small typo in the PR title (tob_k instead of top_k).

MathOpsCorrectnessTest::test_istft5
MathOpsCorrectnessTest::test_istft6
MathOpsCorrectnessTest::test_logdet
MathOpsCorrectnessTest::test_logsumexp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

I see that MathOpsCorrectnessTest::test_logsumexp is being added to the exclusion list. However, the logsumexp function appears to be implemented in the OpenVINO backend (keras/src/backend/openvino/math.py).

Could you clarify why this test is being excluded? If the implementation is correct, this test should be passing. If it's failing, it might indicate a bug in the logsumexp implementation that should be investigated.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

5 participants