-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Added openvino backend support for numpy.median (Issue #30115) #21379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alungriffith
wants to merge
21
commits into
keras-team:master
Choose a base branch
from
alungriffith:median_support_ov
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
80e38da
WIP: median support for OpenVINO back-end
alungriffith 98f982e
Finished median(), linted
alungriffith 9fd5282
Added comments
alungriffith 93797be
Fixed k_value not scalar
alungriffith 97e3852
Fixed squeeze missing axis
alungriffith 4922cee
Fixed missing output and dtype issues
alungriffith 3f56a13
Fixed final median shape issue
alungriffith 77f7859
Fix tuple convert to OpenVINO
alungriffith fbb727a
Fix missing gather axis arguements
alungriffith e66b943
Fix missing range dtype
alungriffith 45ed5bf
Fix range start is scalar
alungriffith 073a48a
NumpyDtypeTest::test_median reinserted
alungriffith 2a926e9
Revert to state of 'Fix missing range dtype'
alungriffith 916faed
2nd fix for range start with scalar
alungriffith 69268d9
Fix missing rank scalar
alungriffith d92b60a
fixed and passed local testing. Submit median for PR
alungriffith 77dc326
test
alungriffith 4e74f2e
fixed x_flatten_rank calculation
alungriffith 8786cfc
added comments following review
alungriffith 04e72cf
comments added and variables renamed to improve clarity. med_1 calcul…
alungriffith 0eeaa5e
added comment to median function
alungriffith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add comments to explain the logic of the algorithm you implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added and some variables renamed to better explain the logic.