Skip to content

Update core.py #21265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

sonali-kumari1
Copy link
Contributor

@sonali-kumari1 sonali-kumari1 commented May 8, 2025

updated function based decorator openvino.core.custom_gradient() with a class based decorator
Fixes #20953

Replaced function based decorator openvino.core.custom_gradient()  with a class based decorator
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (f98b91f) to head (5969ed9).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21265      +/-   ##
==========================================
- Coverage   82.55%   79.80%   -2.75%     
==========================================
  Files         564      564              
  Lines       54629    54629              
  Branches     8493     8493              
==========================================
- Hits        45097    43598    -1499     
- Misses       7442     9001    +1559     
+ Partials     2090     2030      -60     
Flag Coverage Δ
keras 79.62% <0.00%> (-2.74%) ⬇️
keras-jax 63.63% <0.00%> (ø)
keras-numpy 58.76% <0.00%> (ø)
keras-openvino ?
keras-tensorflow 64.05% <0.00%> (ø)
keras-torch 63.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned requested a review from mattdangerw May 9, 2025 09:20
@gbaned gbaned added this to PR Queue May 9, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 9, 2025
@rkazants
Copy link
Contributor

do NOT merge!!! It breaks tests

@sachinprasadhs
Copy link
Collaborator

@rkazants , I the existing code is intentional and if there is no changes required to that, can we close this PR then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

Function openvino.core.custom_gradient() should be a class
5 participants