Interleave optimizer variable creation to restore backward-compatibility #21247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity. Added optimizer variables were orginally interleaved during `build` prior to keras-team#21232, e.g. `{momentum0, velocity0, momentum1, velocity1, ...}`. In keras-team#21232, the order was changed to non-interleaved for some optimizers, e.g. `{momentum0, momentum1, ..., velocity0, velocity1, ...}`. This broke some custom checkpoint serialization compatibility that relied on the order of variables remaining consistent. Here we modify the base function `add_optimizer_variables(...)` to support creating multiple optimizer variables per training variable, and interleaves creation to restore backward compatibility.
|
@hertschuh, this allows the RecML tests to all pass. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21247 +/- ##
==========================================
- Coverage 82.60% 82.59% -0.01%
==========================================
Files 564 564
Lines 54543 54554 +11
Branches 8472 8479 +7
==========================================
+ Hits 45054 45060 +6
- Misses 7402 7405 +3
- Partials 2087 2089 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
google-ml-butler
bot
added
kokoro:force-run
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optimizer variables were orginally interleaved during
buildprior to #21232, e.g.{momentum0, velocity0, momentum1, velocity1, ...}. In #21232, the order was changed to non-interleaved for some optimizers, e.g.{momentum0, momentum1, ..., velocity0, velocity1, ...}. This broke some custom checkpoint serialization compatibility that relied on the order of variables remaining consistent.Here we modify the base function
add_optimizer_variables(...)to support creating multiple optimizer variables per training variable, and interleaves creation to restore backward compatibility.