Skip to content

Conversation

@shashaka
Copy link
Collaborator

@shashaka shashaka commented May 1, 2025

Adds keras.ops.blackman, which computes the Blackman window. Supported across NumPy, TensorFlow, PyTorch, and JAX backends, but not supported on OpenVINO.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (b2fe0a7) to head (e6798c7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/ops/numpy.py 80.00% 1 Missing and 1 partial ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21235   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         564      564           
  Lines       54498    54535   +37     
  Branches     8469     8470    +1     
=======================================
+ Hits        45017    45050   +33     
- Misses       7397     7400    +3     
- Partials     2084     2085    +1     
Flag Coverage Δ
keras 82.41% <88.23%> (+<0.01%) ⬆️
keras-jax 63.67% <44.11%> (-0.02%) ⬇️
keras-numpy 58.80% <47.05%> (-0.02%) ⬇️
keras-openvino 32.99% <29.41%> (+<0.01%) ⬆️
keras-tensorflow 64.09% <64.70%> (-0.01%) ⬇️
keras-torch 63.74% <44.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@gbaned gbaned added this to PR Queue May 2, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 2, 2025
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 4, 2025
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Approved by Reviewer in PR Queue May 4, 2025
@fchollet fchollet merged commit f5171b3 into keras-team:master May 4, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels May 4, 2025
@github-project-automation github-project-automation bot moved this from Approved by Reviewer to Merged in PR Queue May 4, 2025
@shashaka shashaka deleted the blackman branch May 4, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants