Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore error on upload to codecov #18559

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Ignore error on upload to codecov #18559

merged 1 commit into from
Oct 6, 2023

Conversation

sampathweb
Copy link
Collaborator

Sometimes, CodeCov service is not available resulting in error -

[2023-10-06T16:12:22.463Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.2&token=*******&branch=torch-wrapper-serialize&build=6433876874&build_url=https%3A%2F%2Fgithub.com%2Fkeras-team%2Fkeras%2Factions%2Fruns%2F6433876874&commit=3e62eed1cdfa59b51a4fbe48034664078500e291&job=Tests&pr=18498&service=github-actions&slug=keras-team%2Fkeras&name=&tag=&flags=keras%2Ckeras-tensorflow&parent=
[2023-10-06T16:12:52.517Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 502 - 
<html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>502 Server Error</title>
</head>
<body text=#000000 bgcolor=#ffffff>
<h1>Error: Server Error</h1>
<h2>The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds.</h2>
<h2></h2>
</body></html>

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

This error is aparently common - codecov/codecov-action#598

haifeng-jin
haifeng-jin approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Oct 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (25e4fa6) 78.00% compared to head (20ca484) 57.52%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #18559       +/-   ##
===========================================
- Coverage   78.00%   57.52%   -20.49%     
===========================================
  Files         334      334               
  Lines       32351    32351               
  Branches     6313     6313               
===========================================
- Hits        25237    18611     -6626     
- Misses       5546    12330     +6784     
+ Partials     1568     1410      -158
Flag Coverage Δ
keras 57.52% <ø> (-20.39%) ⬇️
keras-jax ?
keras-numpy 57.52% <ø> (ø)
keras-tensorflow ?
keras-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 180 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fchollet
fchollet approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@fchollet fchollet merged commit b811a37 into keras-team:master Oct 6, 2023
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haifeng-jin haifeng-jin haifeng-jin approved these changes

@fchollet fchollet fchollet approved these changes

Assignees

@gbaned gbaned

Labels
size:XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sampathweb @codecov-commenter @fchollet @haifeng-jin @kokoro-team @gbaned