Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on TensorFlow #10929

Merged
merged 4 commits into from
Aug 21, 2018
Merged

Fix CI on TensorFlow #10929

merged 4 commits into from
Aug 21, 2018

Conversation

taehoonlee
Copy link
Contributor

This PR is a follow-up to #10674. Is there a difference between build environments for PRs and the master branch? :( There was no problem in #10674 but the recent CI on the master branch have been failing.

@taehoonlee
Copy link
Contributor Author

@fchollet, I tried the following (A: data_utils_test.py, B: test_multiprocessing.py):

  • Enabling A, Enabling B with WORKERS=2 (success on Update TensorFlow as 1.9 on Travis #10674, but fail on the master)
  • Enabling A, Enabling B with WORKERS=1 (fail on this PR)
  • Enabling A, Disabling B (fail on this PR)
  • Disabling A, Enabling B with WORKERS=2 (fail on this PR)
  • Disabling A, Disabling B (success on this PR, but on the master..?)

If the problem persists after this PR is merged, we may need to revert TensorFlow 1.7 again.

@taehoonlee
Copy link
Contributor Author

Please note that the test coverage rate on TF drops by 1.2-1.3% if the two tests are skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants