Fix check equality between static shape and dynamic shape in test #10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanboliang
commented
Aug 10, 2018
| @@ -128,7 +132,7 @@ def check_single_tensor_operation(function_name, x_shape_or_val, backend_list, * | |||
| assert_list_with_ref(z_list, assert_value_with_ref) | |||
| else: | |||
| assert_list_pairwise(z_list, allclose=assert_value_equality) | |||
| assert_list_keras_shape(z_list) | |||
There was a problem hiding this comment.
Originally z is the output of K.eval which is a numpy ndarray usually. It doesn't have _keras_shape attribute, so not trigger the inside check.
The fix is: we pass into two list, one is tensor list, the other is output value by K.eval. We check the equality between tensor._keras_shape and value.shape.
yanboliang
commented
Aug 10, 2018
| @@ -1144,7 +1144,18 @@ def spatial_2d_padding(x, padding=((1, 1), (1, 1)), data_format=None): | |||
| py_slice(left_pad, input_shape[2] + left_pad), | |||
| py_slice(None)) | |||
| y = T.set_subtensor(output[indices], x) | |||
| y._keras_shape = output_shape | |||
There was a problem hiding this comment.
The keras shape is not correct, actually the test(backend_test.py/test_spatial_2d_padding) already cover this case, but due to the bug mentioned/fixed in this PR, it doesn't complain.
4 tasks
fchollet
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At
backend_test.py, we would like to check the equality between static keras shape and dynamic shape. However, we actually don't trigger this check by mistake in the existing code. See my inline comments for detail.Related Issues
PR Overview