Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the cropping layers. #10865

Merged
merged 5 commits into from
Aug 8, 2018
Merged

Refactoring of the cropping layers. #10865

merged 5 commits into from
Aug 8, 2018

Conversation

gabrieldemarmiesse
Copy link
Contributor

Summary

The computing of the output shape for cropping layers can be done in a single function.
Maybe we could use subclassing later on?

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Dref360
Dref360 approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree that we should have a Cropping abstract class.

@Dref360 Dref360 merged commit 8f4e4f2 into keras-team:master Aug 8, 2018
@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Aug 10, 2018
Merged
4 tasks
@gabrieldemarmiesse gabrieldemarmiesse deleted the refactor_cropping_3 branch September 18, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dref360 Dref360 Dref360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieldemarmiesse @Dref360