Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some code refactoring using transpose_shape in tensorflow_backend.py. Part 2 #10859

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Some code refactoring using transpose_shape in tensorflow_backend.py. Part 2 #10859

merged 1 commit into from
Aug 8, 2018

Conversation

gabrieldemarmiesse
Copy link
Contributor

Summary

Some refactoring.

Related Issues

PR Overview

There was a bug in the code in the channels_last part:

x += reshape(bias, (1, 1, 1, bias_shape[0]))

The new shape should be of size 5, here it is only 4. My refactoring fixes this.

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Dref360
Dref360 approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dref360 Dref360 merged commit 359e762 into keras-team:master Aug 8, 2018
@gabrieldemarmiesse gabrieldemarmiesse deleted the refactoring_data_format_3 branch September 18, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dref360 Dref360 Dref360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieldemarmiesse @Dref360