Let utils.to_categorical support different dtypes. #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Aug 5, 2018
keras/utils/np_utils.py
Outdated
|
|
||
| # Returns | ||
| A binary matrix representation of the input. The classes axis | ||
| is placed last. | ||
| """ | ||
| if not dtype: | ||
| dtype = K.floatx() |
There was a problem hiding this comment.
We should not make np_utils depend on backend, so please hardcode the default 'float32' in the signature. It's not going to break if there's a mismatch with floatx anyway since we cast Numpy data when feeding it to models.
There was a problem hiding this comment.
@fchollet Sorry I misunderstood your comments. I'll fix this.
|
@fchollet I've addressed all comments. Please check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the returned data type of utils.to_categorical is hardcoded. This PR makes it customizable.
Related Issues
#9262
PR Overview