Improve docstrings to enable PEP8 501 #10797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jul 28, 2018
| @@ -55,17 +55,18 @@ def test_image_data_generator(self, tmpdir): | |||
| vertical_flip=True) | |||
| generator.fit(images, augment=True) | |||
|
|
|||
| for x, y in generator.flow(images, np.arange(images.shape[0]), | |||
| N = images.shape[0] | |||
There was a problem hiding this comment.
Avoid capitalized variable names and single-letter variable names; batch_size or num_samples would be better here.
tests/keras/utils/data_utils_test.py
Outdated
| @@ -187,7 +188,8 @@ def test_generator_enqueuer_processes(): | |||
| acc = [] | |||
| for i in range(100): | |||
| acc.append(int(next(gen_output)[0, 0, 0, 0])) | |||
| assert acc != list(range(100)), "Order was keep in GeneratorEnqueuer with processes" | |||
| assert acc != list(range(100)), ( | |||
| "Order was keep in GeneratorEnqueuer with processes") | |||
There was a problem hiding this comment.
This was a pre-existing issue, but prefer using ' as string delimiter for consistency with the rest of the file (likewise for the other string error message below).
|
@fchollet, Updated. |
fchollet
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves docstrings to enable PEP8 501.
cc @yongzx (I have done a backward sweep :) as you did a forward sweep on the
pytest.ini)