Fixing HDF5Matrix .dtype and .shape properties
#10749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding code to the initialization function of `HDF5Matrix` so that `.dtype` and `.shape` reflect the actual values returned by the normalizer
adding tests for normalizer functions that change dtype and shape
kmader
changed the title
.dtype and .shape output.dtype and .shape properties
removing unnecessary whitespace to make pep8 happy
fchollet
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding code to the initialization function of
HDF5Matrixso that.dtypeand.shapereflect the actual values returned by the normalizer. This is particularly important because themodel.fitfunction looks at the shape to determine if the code can be run and if there are changes to shape (random cropping, downsampling, edge removal, ...) performed in the normalizer these are not currently reflected in the.shapeproperty. The dtype mismatch currently does not cause any issues (that I know of) but should also be adjusted as well.Related Issues
#8304
PR Overview