Fix #10737 #10745
Merged
Fix #10737 #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dref360
reviewed
Jul 21, 2018
keras/layers/convolutional.py
Outdated
| @@ -1411,9 +1411,9 @@ class SeparableConv1D(_SeparableConv): | |||
| one of `"channels_last"` or `"channels_first"`. | |||
| The ordering of the dimensions in the inputs. | |||
| `"channels_last"` corresponds to inputs with shape | |||
| `(batch, height, width, channels)` while `"channels_first"` | |||
| `(batch, length, channels)` while `"channels_first"` | |||
There was a problem hiding this comment.
Would be better to be consistent with Conv1D which uses steps
https://github.com/fuzzythecat/keras/blob/398171294c465e6d8b60727ea77efae44609529a/keras/layers/convolutional.py#L305
|
@Dref360 Made the changes, plus some additional ones I could find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #10737
Related Issues
PR Overview