Numpy ndarray should be serialized as Python list. #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the failure case is non-relevant, let me re-trigger it. |
|
This assumes that the deserialization process will know about the expected array dtype. Please add a unit test. |
fchollet
reviewed
Jul 20, 2018
tests/test_model_saving.py
Outdated
| def test_saving_constant_initializer_with_numpy(): | ||
| """ | ||
| Test saving and loading model of constant initializer with numpy ndarray as input. | ||
| """ |
There was a problem hiding this comment.
Please format the docstring like other docstrings, e.g.
"""Test saving and loading model that includes an initializer with numpy input.
"""
fchollet
approved these changes
Jul 20, 2018
|
@fchollet Sure, will do it soon. Thanks. |
This was referenced Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If there is numpy ndarray in a layer config, for example, set
Constant(np.zeros(2,3))as the initializer, the internal representation should be Tensor in backend(not discriminate numpy ndarray or Python list). When serializing it to JSON format, it should be regards as normal Python list. Otherwise, it will throw exception when deserialization(Refer #10718), sincefrom_configdoesn't know(doesn't need) how to deserialize numpy ndarray if there are extra message header.Note: I have verify this fix works well for #10718.
Related Issues
#10718
PR Overview