Removed some unused variables and fixed a formatting error. #10688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
changed the title
fchollet
reviewed
Jul 18, 2018
keras/utils/vis_utils.py
Outdated
| @@ -102,7 +102,6 @@ def model_to_dot(model, | |||
|
|
|||
| # Connect nodes with edges. | |||
| for layer in layers: | |||
| layer_id = str(id(layer)) | |||
There was a problem hiding this comment.
Sounds it would be better to remove the definition on line 110, not this one?
There was a problem hiding this comment.
You are right! My bad.
fchollet
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The exception
eisn't used andlayer_idis redefined later.Also when the ValueError was raised, one would get the following error instead:
Related Issues
PR Overview