Change default fill_mode from nearest to constant

[ozabluda]

The default fill_mode='nearest' (which was there from the very beginning) for points outside the boundaries of the input is contrary to typical value used ('constant') as well as defaults in SciPy, OpenCV, and everything else I know.

Note that this is different from interpolation for for example for load_img (for example see keras-team/keras#8435)

Also see keras-team/keras#2446

Redirected from PR keras-team/keras#8848

[ozabluda]

@fchollet, @Dref360, Maybe this should be merged now. All TF analogs pad with zeros.

https://www.tensorflow.org/api_docs/python/tf/contrib/image/rotate
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/image/resize_with_pad
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/image/resize_with_crop_or_pad
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/image/transform_ops.py#L34
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/image/transform_ops.py#L282

[Dref360]

Hi! I have a list of issues similar to this one. All should be resolved with the new API where we will make a major revision. For discussion please see the keras-team/governance repo. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Oleg Zabluda <notifications@github.com> Sent: Tuesday, September 3, 2019 3:51:32 PM To: keras-team/keras-preprocessing <keras-preprocessing@noreply.github.com> Cc: Frédéric Branchaud-Charron <Frederic.Branchaud-Charron@USherbrooke.ca>; Mention <mention@noreply.github.com> Subject: Re: [keras-team/keras-preprocessing] Change default fill_mode from nearest to constant (#3) @fchollet<https://github.com/fchollet>, @Dref360<https://github.com/Dref360>, Maybe this should be merged now. All TF analogs pad with zeros. https://www.tensorflow.org/api_docs/python/tf/contrib/image/rotate https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/image/resize_with_pad https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/image/resize_with_crop_or_pad https://github.com/tensorflow/addons/blob/master/tensorflow_addons/image/transform_ops.py#L282 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3?email_source=notifications&email_token=ACEPRIUN4DRBC4T3FBVEEEDQH254JA5CNFSM4FC7OXW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZLRDY#issuecomment-527612047>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACEPRISA4TDCWTPW3NGSKNDQH254JANCNFSM4FC7OXWQ>.

[fchollet]

Closing outdated PR. Note that the Keras Preprocessing repository is no longer in use, instead please just use the dataset utilities provided in tf.keras.utils (see docs).