Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to match required Tensorflow versions #918

Merged
merged 6 commits into from
Jun 29, 2022

Conversation

brendenconnors
Copy link
Contributor

@brendenconnors brendenconnors commented Jun 15, 2022

layers.Normalization() does not exist in Tensorflow 2.3.0, which is listed as a requirement.

And Tensorflow_probability 0.11.0 (listed) is stable against tf 2.3.0 shown here https://github.com/tensorflow/probability/releases?page=2

layers.Normalization() does not exist in Tensorflow 2.3.0, which is listed as a requirement.

Tensorflow_probability 0.11.0 (listed) is stable against tf 2.3.0 shown [here](https://github.com/tensorflow/probability/releases?page=2)
@fchollet
Copy link
Contributor

We should target the latest releases whenever possible. Please try it with TF 2.0 and update the requirements accordingly.

Working using latest stable pair of tf/tf_probability. 😃
@brendenconnors
Copy link
Contributor Author

Ran with updated versions and ran correctly without the "experimental" reference. 😃

@fchollet
Copy link
Contributor

Please also update the md and ipynb files.

@brendenconnors
Copy link
Contributor Author

Arxiv link caused issue when creating md/ipynb files. Updated link in .py file and generated md/ipynb files.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet
Copy link
Contributor

There are some failing tests related to special characters:

UnicodeDecodeError: 'utf-8' codec can't decode byte 0x95 in position 704: invalid start byte
The command '/bin/sh -c python autogen.py make' returned a non-zero code: 1
make: *** [Makefile:2: container-test] Error 1

Did you use a non-utf8 character somewhere?

@brendenconnors
Copy link
Contributor Author

brendenconnors commented Jun 21, 2022

Hmm no not that I am aware of. Could it be a Windows issue?

Seeing this Specials character as opposed to the dot locally in md file.
It looks like forward slashes are also being changed to backward slashes in that line? After removing the Specials character and rerunning, I get a further error because of bad escape \m. Probably user error, but seems like maybe windows paths are causing problems.
image

For this part of the displayed page
image

Not really sure when this would happen during generation

Copy link
Contributor Author

@brendenconnors brendenconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back slashes to forward slashes

examples/generative/ipynb/real_nvp.ipynb Outdated Show resolved Hide resolved
examples/generative/md/real_nvp.md Outdated Show resolved Hide resolved
@brendenconnors
Copy link
Contributor Author

updated changes to image path and metadata name. 👍

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fchollet fchollet merged commit 79024ab into keras-team:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants