Clarify why TextVectorization works on CPU #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jun 14, 2022
8bitmp3
commented
Jun 15, 2022
| @@ -614,6 +638,7 @@ print("Model output:", test_output) | |||
|
|
|||
| <div class="k-default-codeblock"> | |||
| ``` | |||
| WARNING:tensorflow:5 out of the last 1567 calls to <function PreprocessingLayer.make_adapt_function.<locals>.adapt_step at 0x7f80ec464a60> triggered tf.function retracing. Tracing is expensive and the excessive number of tracings could be due to (1) creating @tf.function repeatedly in a loop, (2) passing tensors with different shapes, (3) passing Python objects instead of tensors. For (1), please define your @tf.function outside of the loop. For (2), @tf.function has reduce_retracing=True option that can avoid unnecessary retracing. For (3), please refer to https://www.tensorflow.org/guide/function#controlling_retracing and https://www.tensorflow.org/api_docs/python/tf/function for more details. | |||
There was a problem hiding this comment.
@mattdangerw @fchollet Note the warnings in the output after regenerating .md and Jupyter files
8bitmp3
commented
Jun 15, 2022
| Downloading data from https://www.cs.toronto.edu/~kriz/cifar-10-python.tar.gz | ||
| 170498071/170498071 [==============================] - 14s 0us/step | ||
|
|
||
| 2022-06-15 15:02:40.512792: W tensorflow/core/framework/cpu_allocator_impl.cc:82] Allocation of 153600000 exceeds 10% of free system memory. |
There was a problem hiding this comment.
@mattdangerw @fchollet Maybe we should make the output in cells less verbose.
8bitmp3
commented
Jun 15, 2022
| @@ -116,6 +116,14 @@ print("Features std: %.2f" % (normalized_data.numpy().std())) | |||
|
|
|||
| <div class="k-default-codeblock"> | |||
| ``` | |||
| 2022-06-15 15:02:07.223345: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory | |||
There was a problem hiding this comment.
@mattdangerw @fchollet Note the new messages in the output after regenerating the notebook and Markdown files
fchollet
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @fchollet @mattdangerw @MarkDaoust
This PR introduces the following improvements:
TextVectorizationlayer should be used as part of atf.datainput pipeline (runs only on CPUs, won't utilize hardware acceleration if included inside aModel, affecting performance).