Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce keras-io documentation for KerasCV #852

Merged
merged 50 commits into from
May 17, 2022
Merged

Introduce keras-io documentation for KerasCV #852

merged 50 commits into from
May 17, 2022

Conversation

LukeWood
Copy link
Contributor

We can submit this after the v0.1.0 release of KerasCV (I plan to do this in a week~ or so...)

Feedback needed on the guides, and here is a Colab link so you can see the images in the guide:
https://colab.research.google.com/drive/1t3lwXhA1guK3nwIyz1-kIs84OuZUMci5?usp=sharing

I'll be adding a COCO metrics guide tomorrow.

@LukeWood LukeWood mentioned this pull request Apr 13, 2022
Closed
@sayakpaul
Copy link
Contributor

@LukeWood possible to share access to the Colab? I wanna 👀

sayakpaul
sayakpaul suggested changes Apr 13, 2022
View reviewed changes
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
@LukeWood
Copy link
Contributor Author

@fchollet FYI updated the augmentation guide and added an additional guide

@sayakpaul
Copy link
Contributor

@LukeWood changes look good. Thank you!

fchollet
fchollet reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I applied some minor copyedits. The content looks great!

guides/keras_cv/cut_mix_mix_up_and_rand_augment.py Outdated Show resolved Hide resolved
@LukeWood
Copy link
Contributor Author

LGTM, let me know what needs to be done to merge this. Maybe we should wait for 2.9 to go live so we can depend on that in KerasCV instead of tf-nightly?

@LukeWood LukeWood requested a review from fchollet April 15, 2022 19:23
This was referenced Apr 15, 2022
Closed
Closed
Closed
fchollet
fchollet reviewed Apr 16, 2022
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to wait for 2.9 before doing a big publicity push. RC0 is already out, so 2.9 is probably ~2 weeks away.

scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
@fchollet
Copy link
Contributor

How long does it take to generate the new guides on CPU? Pretty quick I assume?

@LukeWood
Copy link
Contributor Author

How long does it take to generate the new guides on CPU? Pretty quick I assume?

Actually I think the ResNet50 training takes a very long time on CPU. COCO metrics run on CPU no matter what, so those are fast.

@LukeWood
Copy link
Contributor Author

Ah, this fails right now because it depends on tf-nightly. Will be fixed on 2.9.

mattdangerw
mattdangerw reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke! Was just peeping this PR to make a similar one for keras-nlp, found some small typos.

templates/api/keras_cv/metrics/metrics.md Outdated Show resolved Hide resolved
templates/keras_cv/index.md Outdated Show resolved Hide resolved
templates/keras_cv/index.md Outdated Show resolved Hide resolved
templates/keras_cv/index.md Outdated Show resolved Hide resolved
@LukeWood
Copy link
Contributor Author

Thanks @mattdangerw - updated

@LukeWood
Copy link
Contributor Author

https://keras.io/getting_started/ecosystem/

@LukeWood
Copy link
Contributor Author

@mattdangerw @fchollet @qlzh727 @martin-gorner FYI new guide added

@LukeWood LukeWood requested review from mattdangerw and fchollet May 3, 2022 21:43
@LukeWood
Copy link
Contributor Author

LukeWood commented May 3, 2022

FYI (all current reviewers) @fchollet @innat @mattdangerw @qlzh727 @sayakpaul there is a new guide on subclassing BaseImageAugmentationLayer. Let me know if you all have any feedback regarding this new guide

sayakpaul
sayakpaul suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseImageAugmentationLayer is going to be amazing!

guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Show resolved Hide resolved
guides/keras_cv/writing_custom_image_augmentations_with_baseimageaugmentationlayer.py Outdated Show resolved Hide resolved
fchollet and others added 25 commits May 16, 2022 21:33
@LukeWood
Copy link
Contributor Author

@fchollet do I need to re-run some sort of autogen script to fix this issue?

@LukeWood
Copy link
Contributor Author

Figured it out

@LukeWood LukeWood merged commit 2f5ac74 into keras-team:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innat innat innat left review comments

@sayakpaul sayakpaul sayakpaul requested changes

@fchollet fchollet fchollet approved these changes

@MarkDaoust MarkDaoust Awaiting requested review from MarkDaoust MarkDaoust is a code owner

@mattdangerw mattdangerw Awaiting requested review from mattdangerw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LukeWood @sayakpaul @fchollet @mattdangerw @innat @kdave123