Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a keras_recipe on using a keras callback to evaluate a non-tensorflow metric #656

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Adds a keras_recipe on using a keras callback to evaluate a non-tensorflow metric #656

merged 3 commits into from
Oct 15, 2021

Conversation

LukeWood
Copy link
Contributor

@LukeWood LukeWood commented Oct 8, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 8, 2021
fchollet
fchollet reviewed Oct 8, 2021
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is great!

examples/keras_recipes/sklearn_metric_callbacks.py Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
examples/keras_recipes/sklearn_metric_callbacks.py Outdated Show resolved Hide resolved
@LukeWood LukeWood force-pushed the master branch 4 times, most recently from 98abdf1 to a63b1b8 Compare October 12, 2021 05:25
@LukeWood LukeWood requested a review from fchollet October 12, 2021 05:26
@LukeWood LukeWood force-pushed the master branch 4 times, most recently from 09abe03 to 6164149 Compare October 12, 2021 05:34
@LukeWood
Copy link
Contributor Author

All comments addressed, can add generated files when necessary

fchollet
fchollet approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I pushed some minor copyedits. Please pull them first, then you can generate the ipynb and md files and add them to the PR 👍

@fchollet fchollet merged commit 4ff707f into keras-team:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeWood @fchollet