Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EfficientNetB0 to EfficientNetB1 in the final line #259

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Change EfficientNetB0 to EfficientNetB1 in the final line #259

merged 4 commits into from
Sep 24, 2020

Conversation

sayakpaul
Copy link
Contributor

With reference to the EfficientNet tutorial the last line tries to load B1 weights into B0 which results in incompatibility problems. Additionally, I think it would be useful to just provide a link to the efficientnet_weight_update_util.py since it does not come with the standard installation.

This PR address the above pointers.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Can you also apply the fix to the generated ipynb and md files?

@sayakpaul
Copy link
Contributor Author

@fchollet just did.

@@ -1,733 +1,766 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprising to see a complete rewrite of the notebook file -- it should just be a 2 line change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here :o

Could it be because I edited it in Colab and committed directly from there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely. You can either apply the edit to the ipynb by hand or regenerate the ipynb with the tutobook.py function py_to_nb (that way you don't have to execute the notebook, which takes time)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Then I will work on the JSON of the ipynb directly so that the state does not get changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet fixed it up.

Operating directly on the JSON of the notebook seems like an easier choice for small changes like this.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 3508713 into keras-team:master Sep 24, 2020
k-w-w pushed a commit to k-w-w/keras-io that referenced this pull request Sep 24, 2020
…#259)

* Bump B0 to B1 in the final line

* Update image_classification_efficientnet_fine_tuning.md

* Bumped to B1

* Updated the lines directly on ipynb
fchollet pushed a commit that referenced this pull request Nov 5, 2020
* Show the encoded text in the preprocessing guide (#261)

* Show the encoded text in the preprocessing guide

* python autogen.py generate_tf_guides preprocessing_layers.py

* python autogen.py add_guide preprocessing_layers.py

* Change EfficientNetB0 to EfficientNetB1 in the final line (#259)

* Bump B0 to B1 in the final line

* Update image_classification_efficientnet_fine_tuning.md

* Bumped to B1

* Updated the lines directly on ipynb

* Add SaveOptions to tutorial.

* add release date

* Add save_traces description to SavedModel guide

Co-authored-by: Mark Daoust <markdaoust@google.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants