-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change EfficientNetB0 to EfficientNetB1 in the final line #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Can you also apply the fix to the generated ipynb and md files?
@fchollet just did. |
@@ -1,733 +1,766 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprising to see a complete rewrite of the notebook file -- it should just be a 2 line change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here :o
Could it be because I edited it in Colab and committed directly from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely. You can either apply the edit to the ipynb by hand or regenerate the ipynb with the tutobook.py
function py_to_nb
(that way you don't have to execute the notebook, which takes time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Then I will work on the JSON of the ipynb directly so that the state does not get changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fchollet fixed it up.
Operating directly on the JSON of the notebook seems like an easier choice for small changes like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
…#259) * Bump B0 to B1 in the final line * Update image_classification_efficientnet_fine_tuning.md * Bumped to B1 * Updated the lines directly on ipynb
* Show the encoded text in the preprocessing guide (#261) * Show the encoded text in the preprocessing guide * python autogen.py generate_tf_guides preprocessing_layers.py * python autogen.py add_guide preprocessing_layers.py * Change EfficientNetB0 to EfficientNetB1 in the final line (#259) * Bump B0 to B1 in the final line * Update image_classification_efficientnet_fine_tuning.md * Bumped to B1 * Updated the lines directly on ipynb * Add SaveOptions to tutorial. * add release date * Add save_traces description to SavedModel guide Co-authored-by: Mark Daoust <markdaoust@google.com> Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
With reference to the EfficientNet tutorial the last line tries to load B1 weights into B0 which results in incompatibility problems. Additionally, I think it would be useful to just provide a link to the
efficientnet_weight_update_util.py
since it does not come with the standard installation.This PR address the above pointers.