Skip to content

Update guides for Keras V3 Saving Compatibility #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

nkovela1
Copy link
Collaborator

This PR updates existing keras-io guides ensuring that the models created are saveable via the new Keras V3 saving format (.keras).

Most changes involve the addition of the @keras.utils.register_keras_serializable() decorator, which should be standard practice for custom objects. Additionally, these guides were updated to use the new standard import keras instead of from tensorflow import keras.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please also regenerate the corresponding md/ipynb files via the add_guide command.

@nkovela1
Copy link
Collaborator Author

Regenerated all the md/ipynb files corresponding with the changes, thanks!

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please revert the changes to the images -- the image source is shared with the keras core guides and we should use their version to stay up to date.

@nkovela1
Copy link
Collaborator Author

Reverted all image changes, thanks!

Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Francois' comments are all resolved and this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants