Skip to content

Conversation

haifeng-jin
Copy link
Collaborator

No description provided.

@fchollet
Copy link
Contributor

Thanks for the PR! Please only include the Python file for the first pass.

@haifeng-jin
Copy link
Collaborator Author

Done. removed the generated files. So the generated files will go through another PR afterwards?

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks great.

@haifeng-jin haifeng-jin requested a review from fchollet March 4, 2023 18:09
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Everything looks great. Two minor comments. Once addressed, please generate the md and ipynb files.

"""
## Takeaways

In this tutorial, we learned the following things about handling failed trials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In this guide, you learn how to handle failed trials in KerasTuner:"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Why use "learn" instead of "learned" here?

@haifeng-jin haifeng-jin requested a review from fchollet March 6, 2023 17:22
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@fchollet fchollet merged commit 1146098 into keras-team:master Mar 7, 2023
@haifeng-jin haifeng-jin deleted the fault branch January 10, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants