-
Couldn't load subscription status.
- Fork 306
Add pad_to_aspect_ratio flag to ImageConverter
#2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pad_to_aspect_ratio flag to ImageConverter
#2045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But two issue before merge..
- formatting needs updating,
pip install -U ruffand reformat - the new test is failing on torch, we should look into it.
|
FIxed the torch resize: keras-team/keras#20797, issue was how they were copying the values from original image to an empty image without proper border consideration. Instead we can just concat with fill value on horizontal/vertical sides, similar to how it is done in jax and tensorflow Skipped the test case as of now once the new release is done we can remove skip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Add
pad_to_aspect_ratioflag which can be useful in some of Vision pipelines.