Skip to content

Conversation

ariG23498
Copy link
Contributor

Related #1992

CC: @ianstenbit

Working Colab Notebook

image

Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one little fix! Thank you!

self.get_zoom_matrix(zooms, mask_hd, mask_wd),
fill_mode=self.fill_mode,
fill_value=self.fill_value,
interpolation=self.interpolation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use "nearest" interpolation for segmentation masks to avoid encoding issues for sparse-encoded masks.

@ariG23498
Copy link
Contributor Author

@ianstenbit how would you want me to add the numeric tests for the segmentation masks?

@ianstenbit
Copy link
Contributor

@ianstenbit how would you want me to add the numeric tests for the segmentation masks?

A fixed-input test is fine with me (e.g. setting the seed of a random input and verifying the numerics of the output against a known set of values), or we can just rely on the demo results which is also fine with me.

@ariG23498
Copy link
Contributor Author

@ianstenbit thanks for the review!

we can just rely on the demo results which is also fine with me.
Cool!

I think this PR is in a good shape to be merged.

@ianstenbit
Copy link
Contributor

@ariG23498 please take a look at the linter error. Once that is fixed I shall merge -- thank you!

@ariG23498
Copy link
Contributor Author

@ianstenbit over to you now!

@ianstenbit
Copy link
Contributor

/gcbrun

@ianstenbit ianstenbit merged commit c740f81 into keras-team:master Aug 22, 2023
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* chore: initial commit

* chore: adding initial tests

* update: readme for preprocessing

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants