Skip to content

Remove pinning of keras-core, set min TF vers to 2.13 #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

Remove pinning of keras-core, set min TF vers to 2.13 #1983

merged 1 commit into from
Jul 27, 2023

Conversation

sampathweb
Copy link
Collaborator

  • Removes pinning of keras-core version so it works on latest.
  • Sets min-TF version as 2.13 since that's the dependency in keras-core
  • Updates minimum python version to 3.8, which is the minimum for TF 2.13

@sampathweb sampathweb requested a review from ianstenbit July 26, 2023 23:15
ianstenbit
ianstenbit approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@ianstenbit
Copy link
Contributor

Note that version_check.py is still only enforcing TF 2.11+, which is intentional because for tf.keras this is a reasonable version check, and our Waymo integration is pinned to TF 2.11 for now.

@ianstenbit ianstenbit merged commit a90e468 into keras-team:master Jul 27, 2023
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
@sampathweb
Remove pinning of keras-core, set min TF vers to 2.13 (keras-team#1983)
e9e368a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ianstenbit ianstenbit ianstenbit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampathweb @ianstenbit