Improve the devcontainer settings #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifeng-jin
changed the title
ianstenbit
reviewed
Mar 15, 2023
| @@ -31,7 +31,7 @@ then | |||
| exit 1 | |||
| fi | |||
| [ $# -eq 0 ] && echo "no issues with flake8" | |||
| black --line-length 80 --check $files | |||
There was a problem hiding this comment.
Just to verify -- if using lint.sh outside of devcontainer, this setting will still be taken from pyproject.toml -- correct?
There was a problem hiding this comment.
Yes, that's correct.
You can try. I use chromebook so not many IDEs are available. I switched from vim and VS code has all the features I need. |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
* update container setup * use black formatting on save * add the flake8 extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the devcontainer setup.
isortandblacksettings topyproject.tomlto make consistent behavior no matter how the commands are run. (Note thatpyproject.tomlis just there for the formatting setup not for package releases).ghinside devcontainers.settingsindevcontainer.jsondid not work.