Skip to content

Conversation

jbischof
Copy link
Contributor

@jbischof jbischof commented Mar 7, 2023

Serialization is not needed for the aliases in order for test_saved_alias_model to pass. Since these are thin subclasses of ResNetV2Backbone, calling keras.utils.get_serialized_object points to the base class anyway.

>>> keras.utils.serialize_keras_object(keras_cv.models.ResNet50V2Backbone())
{'class_name': 'keras_cv.models>ResNetV2Backbone', 'config': {'stackwise_filters': ListWrapper([64, 128, 256, 512]), 'stackwise_blocks': ListWrapper([3, 4, 6, 3]), 'stackwise_strides': ListWrapper([1, 2, 2, 2]), 'include_rescaling': True, 'input_shape': (None, None, 3), 'stackwise_dilations': ListWrapper([1, 1, 1, 1]), 'input_tensor': None, 'block_type': 'block', 'name': 'res_net_v2_backbone', 'trainable': True}}

@jbischof jbischof requested a review from ianstenbit March 7, 2023 00:26
Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I need to improve my branch naming game to keep up 💯

@ianstenbit
Copy link
Contributor

/gcbrun

@ianstenbit ianstenbit merged commit cee50ad into keras-team:master Mar 8, 2023
@jbischof jbischof deleted the serial_killer branch March 14, 2023 02:02
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants