Skip to content

Conversation

ianstenbit
Copy link
Contributor

@ianstenbit ianstenbit commented Mar 3, 2023

This change has already been made downstream and I'm syncing it here (since we don't have piper -> copybara set up).

@ianstenbit ianstenbit requested review from lengzq and LukeWood March 3, 2023 17:21
@ianstenbit ianstenbit requested a review from LukeWood March 7, 2023 21:00
@@ -60,11 +60,14 @@ def __init__(
theta_width,
phi_width,
drop_rate=None,
exclude_class=-1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: classes

Copy link
Contributor

@LukeWood LukeWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvod with a nit, happy to delegate on this

@ianstenbit
Copy link
Contributor Author

/gcbrun

@ianstenbit ianstenbit merged commit ad31fe8 into keras-team:master Mar 7, 2023
@soma2000-lang
Copy link
Contributor

soma2000-lang commented Mar 11, 2023

@ianstenbit @LukeWood just want to educate myself on this part ,why we are excluding the class params to some 3d processing layers?

@ianstenbit
Copy link
Contributor Author

@ianstenbit @LukeWood just want to educate myself on this part ,why we are excluding the class params to some 3d processing layers?

The purpose here is to allow specifying classes that shouldn't be affected by these layers. There will be an upcoming blog post in the next few months about the usage of these layers which should help demonstrate the use case!

ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
…zq (keras-team#1459)

* Add exclude_class param to some 3D preprocessing layers. Original author: lenzq

* Make exclude_class support None or a list

* Rename to exclude_classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants