Skip to content

Conversation

IMvision12
Copy link
Contributor

@IMvision12 IMvision12 commented Feb 28, 2023

@ianstenbit ianstenbit self-requested a review March 6, 2023 15:24
Copy link
Contributor

@ianstenbit ianstenbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thank you!

@ianstenbit
Copy link
Contributor

/gcbrun

@ianstenbit
Copy link
Contributor

Test failure looks real. Please take a look -- thanks!

blocks = float(sum(args["num_repeat"] for args in blocks_args))
KeyError: 'num_repeat'

@IMvision12
Copy link
Contributor Author

blocks_args = DEFAULT_BLOCKS_ARGS["efficientnetv2-b0"]
blocks = float(sum(args["num_repeat"] for args in blocks_args))
print(blocks)

Not sure why the test is failing, I tested the above code and it works fine

@ianstenbit
Copy link
Contributor

@IMvision12 based on the error message (are you able to see it?), this is related to serialization / from_config. I'd guess the blocks_args param isn't being serialized correctly (possibly because in this case what's passed in is "default" but what we serialize is the full dictionary -- we could fix this by making a copy of the input blocks_args param and store that on self.blocks_args)

You should be able to run this test locally with PyTest to test further.

@IMvision12
Copy link
Contributor Author

Oh, yeah i didn't see that

@IMvision12 IMvision12 requested a review from ianstenbit March 6, 2023 20:19
@IMvision12
Copy link
Contributor Author

=========================================== test session starts ===========================================
platform win32 -- Python 3.9.10, pytest-7.2.2, pluggy-1.0.0
rootdir: F:\effi\keras-cv, configfile: setup.cfg
collected 6 items

keras_cv\models\efficientnet_v2_test.py .....s                                                       [100%]

====================================== 5 passed, 1 skipped in 14.60s ======================================

@ianstenbit
Copy link
Contributor

/gcbrun

@IMvision12
Copy link
Contributor Author

@ianstenbit, would we be interested in integrating SSD (Single Shot Detector) models to kcv? I was thinking about working on it.

@ianstenbit
Copy link
Contributor

@ianstenbit, would we be interested in integrating SSD (Single Shot Detector) models to kcv? I was thinking about working on it.

I'd open an issue about it and tag LukeWood -- I think in general new OD models are something we're interested in, but prioritizing YOLOx and YOLOv8 first.

@ianstenbit ianstenbit merged commit c4d3b51 into keras-team:master Mar 6, 2023
@IMvision12 IMvision12 deleted the EfficientNetV2 branch March 6, 2023 21:39
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* update

* docs

* docs

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make EfficientNetV2 a Functional subclass model & remove closures
2 participants