Enforce line length of 80 chars #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
bhack
reviewed
Feb 16, 2023
LukeWood
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
fine by me as long as @haifeng-jin has no specific reason for 88.
we took 88 from keras-tuner, dont think it should be an issue as long as it is uniform. LGTM
|
/gcbrun |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
* Enforce line length of 80 chars * Add 80 char limit to `flake8` as well * Apply formatting to merged changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line length is currently set at 88 chars. Bring this back to 80 chars to agree with Keras and KerasNLP.
Note that this does not work for docstrings and comments. We have exempted them to allow for hyperlinks.