Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalization channel dimension is not calculated during trace time #431

Open
quantumalaviya opened this issue May 12, 2022 · 2 comments
Open

Comments

@quantumalaviya
Copy link
Contributor

There are a few issues I faced while trying to use the Equalization layer with AugMix in #407

The channel dimension is not calculated during trace time (I believe due to the vectorized_map from #201). This makes it incompatible with other layers in a chain. Moreover, this is the only layer that gets traced every time it's called. It's not ideal and repeated occurrences of this layer are very inefficient.

@LukeWood
Copy link
Contributor

Definitely, Equalization should be updated. Thanks for doing some digging here.

I believe these changes were introduced by my PR that adds support for dynamic channel sizes; but this behavior is very undesirable.

@LukeWood LukeWood changed the title Equalization may need changes Equalization channel dimension is not calculated during trace time May 12, 2022
Copy link

This issue is stale because it has been open for 180 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants