-
Notifications
You must be signed in to change notification settings - Fork 118
Small ops fixes for Torch unit tests #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
0f38d06
Add PyTorch numpy functionality
nkovela1 1db99e4
Add dtype conversion
nkovela1 d2a6297
Sync with torch name change
nkovela1 be982ea
Partial fix for PyTorch numpy tests
nkovela1 9974305
small logic fix
nkovela1 db32301
Revert numpy_test
nkovela1 1b24426
Add tensor conversion to numpy
nkovela1 d14b59a
Fix some arithmetic tests
nkovela1 96d044b
Fix some torch functions for numpy compatibility
nkovela1 f0224ea
Fix pytorch ops for numpy compatibility, add TODOs
nkovela1 fb0a33a
Fix formatting
nkovela1 581a566
Implement nits and fix dtype standardization
nkovela1 d3163d1
Add pytest skipif decorator and fix nits
nkovela1 6a1e1b5
Fix formatting and rename dtypes map
nkovela1 cd5f124
Split tests by backend
nkovela1 8095653
Sync with main
nkovela1 e574586
Merge space
nkovela1 b68e31e
Fix dtype issues from new type checking
nkovela1 38897de
Implement torch.full and torch.full_like numpy compatible
nkovela1 ef990d6
Implements logspace and linspace with tensor support for start and stop
nkovela1 a59390a
Replace len of shape with ndim
nkovela1 43a5480
Fix formatting
nkovela1 418e187
Implement torch.trace
nkovela1 b45a4ee
Implement eye k diagonal arg
nkovela1 52847eb
Implement torch.tri
nkovela1 7b80426
Fix formatting issues
nkovela1 d5d38e8
Fix torch.take dimensionality
nkovela1 bd4979c
Add split functionality
nkovela1 40e7ccb
Revert torch.eye implementation to prevent conflict
nkovela1 51aa764
Implement all padding modes
nkovela1 9879678
Sync and merge with main
nkovela1 d53e52d
Merge branch 'main' into nkovela-pytorch
nkovela1 82892fd
Adds torch image resizing and torchvision dependency.
nkovela1 1518f4c
Fix conditional syntax
nkovela1 7ba937f
Make torchvision import optional
nkovela1 64760fd
Merge branch 'main' into nkovela-pytorch
nkovela1 193e558
Partial implementation of torch RNN
nkovela1 3efd465
Merge branch 'main' into nkovela-pytorch
nkovela1 d651ca9
Duplicate torch demo file
nkovela1 f0033ff
Merge branch 'main' into nkovela-pytorch
nkovela1 89c0f31
Small ops fixes for torch unit tests
nkovela1 7dee1f4
Merge branch 'main' into nkovela-pytorch
nkovela1 f25229b
delete nonfunctional gpu test file
nkovela1 fdc4668
Revert rnn and formatting fixes
nkovela1 d05a2a5
Revert progbar
nkovela1 7f34d89
Fix formatting
nkovela1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is torch related, can we move it to the torch backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling mish in activations.py does x * backend.nn.tanh(backend.nn.softplus(x)) a few lines above this, and this will multiply a numpy array (x) by a Torch tensor, which is not allowed. The conversion to a tensor for x (first arg) must therefore be done here.