-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding twitter mentions #8
Conversation
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Hey @nehagup I have used the template from out blog-website. I can also alter the design if this does'nt suit the website. Will be waiting on feedback from you guys. I have also added to increase the scale on hover please tell if does'nt work with it. |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Hey @Hermione2408 I have pushed the changes! |
components/TwitterTestimonials.tsx
Outdated
"Looks amazing. I hear about eBPF a lot, but I don't know what it is. The automated testing tool “Keploy” using eBPF is amazing", | ||
}, | ||
]; | ||
console.log(tweets.length) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it!
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
LGTM @nehagup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aditya-eddy this would require a few changes to merge.
- Please move this section above "keploy test coverage challenge"
- Also reduce the number of cards to 6 in case of mobile
- Also the zoom in animation doesn't fit well with mobile screens where the cards just fit in the whole screen.
- There's no margin left in between cards when someone hovers over, please reduce the scale of animation.
- Please rename the section to "We love when users talk about Keploy.."
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Hey @nehagup i have made the required changes: |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aditya-eddy rest looks good! Just that section title needs padding, please refer to other sections. Maintain the theme.
Hey @nehagup i have added the padding: |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aditya-eddy with the screenshot I shared earlier, I meant to add the padding in the testimonial section title. I see it's still not there

Hey @nehagup i was confused because of screenshot have fixed it now! |
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aditya-eddy ! LGTM! 👏
* Adding twitter mentions Signed-off-by: Aditya-eddy <aditya282003@gmail.com> * pushing the changes Signed-off-by: Aditya-eddy <aditya282003@gmail.com> * adding above changes Signed-off-by: Aditya-eddy <aditya282003@gmail.com> * adding required changes Signed-off-by: Aditya-eddy <aditya282003@gmail.com> * adding the padding Signed-off-by: Aditya-eddy <aditya282003@gmail.com> * adding padding Signed-off-by: Aditya-eddy <aditya282003@gmail.com> --------- Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
fixes Issue