Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding twitter mentions #8

Merged
merged 9 commits into from
Mar 31, 2024

Conversation

Aditya-eddy
Copy link
Member

fixes Issue

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Aditya-eddy
Copy link
Member Author

Aditya-eddy commented Mar 18, 2024

Hey @nehagup I have used the template from out blog-website. I can also alter the design if this does'nt suit the website. Will be waiting on feedback from you guys.
Screenshot:-
Screenshot from 2024-03-18 15-29-05
Screenshot from 2024-03-18 15-52-25

I have also added to increase the scale on hover please tell if does'nt work with it.

@nehagup nehagup requested a review from Hermione2408 March 18, 2024 14:05
Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Aditya-eddy
Copy link
Member Author

Hey @Hermione2408 I have pushed the changes!

"Looks amazing. I hear about eBPF a lot, but I don't know what it is. The automated testing tool “Keploy” using eBPF is amazing",
},
];
console.log(tweets.length)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this console

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it!

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Hermione2408
Copy link
Member

LGTM @nehagup

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-eddy this would require a few changes to merge.

  • Please move this section above "keploy test coverage challenge"
  • Also reduce the number of cards to 6 in case of mobile
  • Also the zoom in animation doesn't fit well with mobile screens where the cards just fit in the whole screen.
  • There's no margin left in between cards when someone hovers over, please reduce the scale of animation.
  • Please rename the section to "We love when users talk about Keploy.."

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Aditya-eddy
Copy link
Member Author

Hey @nehagup i have made the required changes:
Screenshot from 2024-03-28 13-41-30
Screenshot from 2024-03-28 13-41-20

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-eddy rest looks good! Just that section title needs padding, please refer to other sections. Maintain the theme.
Screenshot 2024-03-28 at 5 07 25 PM

@Aditya-eddy
Copy link
Member Author

Hey @nehagup i have added the padding:
Screenshot from 2024-03-29 08-40-50
Screenshot from 2024-03-29 08-33-07

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-eddy with the screenshot I shared earlier, I meant to add the padding in the testimonial section title. I see it's still not there

Screenshot 2024-03-29 at 11 03 14 PM

@Aditya-eddy
Copy link
Member Author

Hey @nehagup i was confused because of screenshot have fixed it now!

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aditya-eddy ! LGTM! 👏

@nehagup nehagup merged commit 4cbceaf into keploy:main Mar 31, 2024
1 check passed
Hermione2408 pushed a commit that referenced this pull request Mar 31, 2024
* Adding twitter mentions

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

* pushing the changes

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

* adding above changes

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

* adding required changes

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

* adding the padding

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

* adding padding

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>

---------

Signed-off-by: Aditya-eddy <aditya282003@gmail.com>
@Aditya-eddy Aditya-eddy deleted the branch_addTwitterMentions branch April 3, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: add twitter mentions on keploy website
3 participants