Simplified endpoint paths with @RequestMapping("/potions"), renamed m…#104
Closed
AnshumaanRath wants to merge 1 commit intokeploy:mainfrom
Closed
Simplified endpoint paths with @RequestMapping("/potions"), renamed m…#104AnshumaanRath wants to merge 1 commit intokeploy:mainfrom
AnshumaanRath wants to merge 1 commit intokeploy:mainfrom
Conversation
…ethods for clarity, standardized response handling with ResponseEntity and proper status codes, used .orElseThrow() for cleaner Optional handling, removed unused code/imports, and improved variable naming for readability.
|
Hey @AnshumaanRath, Thank you for raising the pr! Our team will soon review this changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the structure and quality of the PotionController and PotionServiceImpl classes.
✅ Changes Made
Added @RequestMapping("/potions") to simplify endpoint paths.
Renamed methods for clarity (getAllPotion → getAllPotions).
Standardized response handling using ResponseEntity with appropriate status codes (201, 204).
Replaced verbose Optional handling with .orElseThrow().
Cleaned up unused imports and commented-out code.
Improved variable naming for better readability.
🚀 Areas for Improvement
Add input validation using annotations (@notblank, @NotNull).
Write unit tests with JUnit and Mockito.
Implement global exception handling with @ControllerAdvice.
Add Swagger for API documentation.
Consider using DTOs to separate internal models from API responses.