Skip to content

fix: remove defered resp closer from for loop #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slayerjain wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove defered resp closer from for loop #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions keploy/keploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,8 +616,6 @@ func (k *Keploy) fetch() []models.TestCase {
k.Log.Error("failed to fetch testcases from keploy cloud", zap.Error(errors.New("failed to send get request: "+resp.Status)))
return nil
}

defer resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
k.Log.Error("failed to fetch testcases from keploy cloud", zap.Error(err))
Expand All @@ -631,13 +629,18 @@ func (k *Keploy) fetch() []models.TestCase {
return nil
}
tcs = append(tcs, res...)
if len(res) < pageSize {
break
}
eof := resp.Header.Get("EOF")
err = resp.Body.Close()
if err != nil {
k.Log.Error("failed to close keploy resp while fetching testcases from keploy", zap.Error(err))
}
if eof == "true" {
break
}

if len(res) < pageSize {
break
}
}
return tcs
}
Expand Down